Skip to content

Conversation

@ydah
Copy link
Contributor

@ydah ydah commented Dec 26, 2025

Overview

This PR Bump rubocop and related plugin versions.

We also resolved the runtime warnings that occurred during the version update. However, newly added warnings have been temporarily suppressed by adding them to the todo list. We can address these warnings sequentially, allowing this PR to focus solely on the version upgrade.

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Add new tests for your change, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Confirm all checks passed
  • Open a separate PR to add a CHANGELOG entry

ydah added 3 commits December 26, 2025 03:59
1. Migrate to the plugin system in .rubocop.yml (replaced `require` with `plugins`).
2. Rename `Naming/PredicateName` to `Naming/PredicatePrefix`.
3. Remove redundant `Metrics/AbcSize` disable directives from:
   - lib/new_relic/agent/instrumentation/curb/chain.rb
   - lib/new_relic/agent/span_event_primitive.rb
   - lib/new_relic/agent/transaction.rb
@ydah ydah requested a review from a team as a code owner December 26, 2025 01:45
@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Dec 26, 2025
@hannahramadan hannahramadan merged commit 20bfc93 into newrelic:dev Dec 31, 2025
55 checks passed
@ydah ydah deleted the bump-rubocop branch January 1, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community To tag external issues and PRs submitted by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants