Fix test compatibility with Bundler 4.0+ (all_specs removal) #3381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes test failure when running with Bundler 4.0+ by skipping a test that validates behavior for old Bundler versions that no longer applies. ## Problem The test `test_rubygems_specs_works_with_all_specs_when_installed_specs_is_absent` was failing with Bundler 4.0.3+ because: - Bundler 4.0 removed `Bundler.rubygems.all_specs` in favor of `Bundler.rubygems.installed_specs` - The test was attempting to simulate old Bundler behavior by stubbing `respond_to?` and then calling `all_specs` - Since `all_specs` no longer exists in Bundler 4.0+, this raises a `Bundler::RemovedError` ## Solution Added a skip condition to the test when running with Bundler 4.0+, as the scenario it tests (old Bundler without `installed_specs`) is no longer relevant for modern Bundler versions. The implementation code in `lib/new_relic/helper.rb` already handles this correctly by: 1. First checking if `installed_specs` is available (Bundler 2.5.12+) 2. Falling back to `all_specs` only for very old Bundler versions
|
|
github-actions
bot
added
the
community
hannahramadan
approved these changes
Dec 30, 2025
Contributor
hannahramadan
left a comment
hannahramadan
left a comment
There was a problem hiding this comment.
Thank you for both catching and fixing this test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes test failure when running with Bundler 4.0+ by skipping a test that validates behavior for old Bundler versions that no longer applies.
Problem
The test
test_rubygems_specs_works_with_all_specs_when_installed_specs_is_absentwas failing with Bundler 4.0.3+ because:Bundler.rubygems.all_specsin favor ofBundler.rubygems.installed_specsrespond_to?and then callingall_specsall_specsno longer exists in Bundler 4.0+, this raises aBundler::RemovedErrorSolution
Added a skip condition to the test when running with Bundler 4.0+, as the scenario it tests (old Bundler without
installed_specs) is no longer relevant for modern Bundler versions.The implementation code in
lib/new_relic/helper.rbalready handles this correctly by:installed_specsis available (Bundler 2.5.12+)all_specsonly for very old Bundler versionsBefore contributing, please read our contributing guidelines and code of conduct.
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist