CI changes #3378
Merged
CI changes #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SimpleCov Report
|
tannalynn
commented
Dec 18, 2025
| ['7.3.9', 2.7], | ||
| ['6.4.0'], | ||
| ['5.0.3'] | ||
| ['5.0.3', 2.6, 2.6] |
Contributor
Author
There was a problem hiding this comment.
when we removed the min ruby versions when we dropped 2.4 and 2.5, here we accidentally removed the max ruby version of 2.6 to run the tests on, so that's why jruby started having problems.
tannalynn
commented
Dec 18, 2025
| on: | ||
| pull_request: | ||
| branches: | ||
| - main |
Contributor
Author
There was a problem hiding this comment.
removing this because now we have perfverse, and also one of the github actions we run to upload the results to slack is having problems.
tannalynn
commented
Dec 18, 2025
| # stubbing it weirdly bc jruby | ||
| default_source = Object.new | ||
| default_source.stubs(:allowlist_for).returns(nil) | ||
| default_source.define_singleton_method(:allowlist_for) do |k| |
Contributor
Author
There was a problem hiding this comment.
the changes in this file are all related to one of the 10.0 changes. these tests are new and were never stubbed to run correctly on jruby.
chynesNR
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passing jruby run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/20349177631