Validate record_custom_event type
#3319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
record_custom_event type
Contributor
SimpleCov Report
|
tannalynn
reviewed
Nov 13, 2025
Contributor
tannalynn
left a comment
tannalynn
left a comment
There was a problem hiding this comment.
We should probably add a changelog entry for this since customers could see different behavior now if they were using it wrong previously. That way they'll know why it is acting differently for them.
kaylareopelle
requested changes
Nov 13, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
I'm requesting changes for the changelog entry, just so that I don't keep opening up the PR wondering why I haven't approved it yet! 😅
Contributor
Author
|
@kaylareopelle changelog done! |
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
kaylareopelle
approved these changes
Nov 14, 2025
….com/newrelic/newrelic-ruby-agent into record_custom_event_raise_on_invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NewRelic::Agent#record_custom_eventAPI will now raise anArgumentErroron an invalidevent_type.A valid
event_typemust consist of only alphanumeric characters,_,:, orcloses #3126