Ruby 4.0 support - Add logger as a dependency
#3293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
logger as a dependencylogger as a dependency
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Do you think we need a changelog entry for this? Otherwise, LGTM!
Contributor
|
Another thought -- wdyt about changing the PR title to include "Ruby 3.5 support" or something like that to make it easier to search later on? |
kaylareopelle
approved these changes
Nov 12, 2025
kaylareopelle
requested changes
Nov 12, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
jkjk - I think we should add a changelog entry, at least for the logger part. open to other opinions though!
hannahramadan
changed the title
logger as a dependencylogger as a dependency
Contributor
Author
|
@kaylareopelle changed both the title and added that changelog entry! https://github.com/newrelic/newrelic-ruby-agent/pull/3293/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR8-R10 |
kaylareopelle
approved these changes
Nov 12, 2025
hannahramadan
changed the title
logger as a dependencylogger as a dependency
hannahramadan
changed the title
logger as a dependencylogger as a dependency
Contributor
Author
|
Updated the changelog to reflect the eventual change of ruby 3.5 to ruby 4.0 |
Contributor
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
loggergem as an agent dependency.loggeris no longer a part of Ruby default gems starting from Ruby 4.0.0, but agent code is quite intertwined with it and all other Ruby versions we support include it as a default, so adding it as a dependency makes sense.This PR also updates tests to account for the removal of
loggerandbenchmarkfrom Ruby 4.0.0.Full CI run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/17749090770
(This PR was created when Ruby 3.5.0 was the planned release for Christmas 2025 instead of 4.0.0)