-
Notifications
You must be signed in to change notification settings - Fork 607
Remove Language Agent Security Policies (LASP) #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks, @hannahramadan. Do you think we need a changelog entry?
| @@ -1,269 +0,0 @@ | |||
| [{ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should open a PR to remove the language_agents_security_policies cross-agent test altogether?
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall! Noticed one small typo. Also, a reminder about the changelog entry. Happy to discuss if you think we don't need one.
I think a changelog entry is a good idea, even though no one uses it. like, we might be asked someday "what version stopped supporting this" and that would make it easier to know. We can just say it was an experimental feature that was never released and is now removed or something |
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes on this one too for the changelog entry based on our convo during standup
Co-authored-by: Kayla Reopelle <[email protected]>
|
@kaylareopelle @tannalynn - added a changelog! There was a line in the spec: |
SimpleCov Report
|
Remove the experimental feature Language Agent Security Policies (LASP) and its related tests.
LASP was known externally as Configurable Security Policies (CSP).
closes #3325