-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(nginx): add nginx OTel support #22554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hi @sairaj18 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Please ensure the propsed changes look good by building it first in your local environment. Refer to this contribution guide to get the site up and running in your local. If you really require a preview url, reach out to one of the writers and they will generate one for you. |
6df77cf to
114d367
Compare
114d367 to
c35c665
Compare
|
netlify build fork |
|
✅ Your PR has been mirrored to our repository as PR #22557. |
7ab9084 to
0b52dcd
Compare
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
| 4. Restart the collector to apply the changes: | ||
|
|
||
| ```bash | ||
| sudo systemctl restart otelcol-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed again? Since the logs are a mandatory step can we have everything included in a single step? May I know why was this split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made configuring logs optional because by default we don't want the ingest to be too high. So, this will be a separate step and users should restart the collector once they update their config to ingest logs.
| - [OpenTelemetry Collector Contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/latest) installed and running on a linux host | ||
| - Network access from the linux host to: | ||
| - NGINX HTTP stub status endpoint | ||
| - Anyone of the [New Relic OTLP](https://docs.newrelic.com/docs/opentelemetry/best-practices/opentelemetry-otlp/#configure-endpoint-port-protocol:~:text=HTTP-,Endpoint,-Supported%20ports) enpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify it to the correct URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the url.
26247f7 to
58dde37
Compare
… files, create a single file for each deployment type
58dde37 to
3b1c78e
Compare
Quick start PR - newrelic/newrelic-quickstarts#2719
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
links to related docs, screenshots, etc.