Fix: Make parameters explicitly nullable for PHP 8.4 compatibility #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses deprecation warnings identified by PHPCompatibility
and PHPStan related to implicitly nullable parameters. In PHP 8.4,
implicitly marking a parameter as nullable by providing a default null
value without using the explicit '?' nullable type hint will be
deprecated.
The following changes were made:
- In `src/N98/Util/Http/DownloadException.php`:
- The `$previous` parameter in the `__construct` method is now
explicitly nullable (`?Throwable`).
- In `src/N98/Magento/Command/Developer/Console/Shell.php`:
- The `$input` parameter in the `run` method is now explicitly
nullable (`?InputInterface`).
- The `$output` parameter in the `run` method is now explicitly
nullable (`?OutputInterface`).
These changes ensure that the codebase remains compatible with upcoming
PHP versions and adheres to stricter type checking.
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses deprecation warnings identified by PHPCompatibility and PHPStan related to implicitly nullable parameters. In PHP 8.4, implicitly marking a parameter as nullable by providing a default null value without using the explicit '?' nullable type hint will be deprecated.
The following changes were made:
In
src/N98/Util/Http/DownloadException.php:$previousparameter in the__constructmethod is now explicitly nullable (?Throwable).In
src/N98/Magento/Command/Developer/Console/Shell.php:$inputparameter in therunmethod is now explicitly nullable (?InputInterface).$outputparameter in therunmethod is now explicitly nullable (?OutputInterface).These changes ensure that the codebase remains compatible with upcoming PHP versions and adheres to stricter type checking.
Magerun pull-request check-list:
Summary: (some words as summary)
Fixes #1659