Fix(actions): Standardize PHP/Composer in magento_platform_tests #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've standardized the PHP and Composer versions used for building and testing the PHAR within the magento_platform_tests.yml workflow. Changes: - I modified the "Setup PHP for phar build" step in .github/workflows/magento_platform_tests.yml to use `matrix.php-version` and `matrix.composer-version` instead of hardcoded PHP 8.2 and Composer v2. This ensures consistency with the PHP/Composer versions used for Magento installation and initial PHPUnit tests within each matrix job. - The `build.sh` script was previously updated to remove redundant Composer download logic, relying on `setup-php` to provide Composer. This change is implicitly included. These changes aim to resolve failures in the Magento Platform Tests GitHub Action by ensuring the PHAR is built and tested in an environment consistent with the rest of the matrix job's setup, reducing potential incompatibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've standardized the PHP and Composer versions used for building and testing the PHAR within the magento_platform_tests.yml workflow.
Changes:
These changes aim to resolve failures in the Magento Platform Tests GitHub Action by ensuring the PHAR is built and tested in an environment consistent with the rest of the matrix job's setup, reducing potential incompatibilities.
Magerun pull-request check-list:
Changes proposed in this pull request:
matrix.php-versionandmatrix.composer-versioninstead of hardcoded PHP 8.2 and Composer v2. This ensures consistency with the PHP/Composer versions used for Magento installation and initial PHPUnit tests within each matrix job.build.shscript was previously updated to remove redundant Composer download logic, relying onsetup-phpto provide Composer. This change is implicitly included.