Skip to content

Conversation

@cmuench
Copy link
Member

@cmuench cmuench commented Apr 21, 2025

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)
  • phar fuctional test (in tests/phar-test.sh)

Summary: Extends the sys:store:config:base-url:list command by adding url for the admin store

Fixes possible #1545

Changes proposed in this pull request:

  • add new option --with-admin-store to add the store with ID 0 to the list
  • add new option --with-admin-login-url to print the whole URL of store 0 appended by admin login url

@github-actions
Copy link

github-actions bot commented Apr 21, 2025

Download the artifacts for this pull request:

@cmuench
Copy link
Member Author

cmuench commented Apr 21, 2025

I will add the plain uri to sys:info command, too.
See: #1620

@cmuench cmuench marked this pull request as ready for review April 21, 2025 14:24
@cmuench cmuench merged commit 9751100 into netz98:develop Apr 21, 2025
13 checks passed
@cmuench cmuench added this to the 8.1.0 milestone Apr 21, 2025
@cmuench cmuench deleted the feature/1545-admin-url branch June 21, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant