Skip to content

config:store:get does not read config.php or env.php, or default xml #712

@convenient

Description

@convenient

Current Implementation

When you have config stored in env.php and config.php then using config:store:get can produce values which arent actually used on the site.

For example putting into env.php

    'system' => [
        'default' => [
            'admin' => [
                'security' => [
                    'session_lifetime' => 31536000
                ]
            ],
        ]
    ]
];

Then running config:store:get we get the value from core_config_data which won't actually be used in the system.

$ magerun2 config:store:get admin/security/session_lifetime
+---------------------------------+---------+----------+-------+
| Path                            | Scope   | Scope-ID | Value |
+---------------------------------+---------+----------+-------+
| admin/security/session_lifetime | default | 0        | 86400 |
+---------------------------------+---------+----------+-------+

However magentos config:show command properly reads it

$ php bin/magento config:show admin/security/session_lifetime
31536000

If you remove the value from env.php then magentos config:show properly falls back to core_config_data

php bin/magento config:show admin/security/session_lifetime
86400

Suggested Enhancement

It would be neat if we could have config:store:get read default.xml, config.php, and env.php appropriately.

I really like mageruns ability to search with wildcards like '%yotpo%' but we cant trust the output of that based on the hardcoded values.

I'm working around this by php bin/magento config:show | grep yotpo

Expected Benefits

More truthful values of the actual configuration used on the site. I'm not sure how easy or difficult this is, or whether it would end up as a copy of config:show but with differing pattern matching after the full list of config has been worked out?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions