db:dump --strip option misses exporting structure in databases with table prefixes

[martin-cod]

Describe the bug

Given
Magento Database with tables prefix, i.e. prefix_
magerun2 version 9.1.0 or 9.0.2

When

Executing the command with --strip option, i.e.

magerun2.phar db:dump --no-tablespaces --strip="sales_invoice" --only-command dump.sql

Then

Result is the following:

mysqldump --single-transaction --quick --no-tablespaces --column-statistics=0  --ignore-table=database.prefix_sales_invoice 'database'

Expected

mysqldump --single-transaction --quick --no-tablespaces --column-statistics=0 --no-data 'database' prefix_sales_invoice
mysqldump --single-transaction --quick --no-tablespaces --column-statistics=0  --ignore-table=database.prefix_sales_invoice 'database'

So, the structure of stripped tables is missed when tables are prefixed. --strip turns into --exclude in this case

Expected behaviour

The --strip option works the same as for the databases where tables are not prefixed.

Extra info

I use a shared config among different servers with custom table groups. --strip option doesn't work on servers where tables are prefixed. Default table groups, like @admin and @sales don't work either.

[cmuench]

@martin-cod Thanks. Sadly this logic seems to be very complex in the meantime. I tried to document the behaviour here: https://netz98.github.io/n98-magerun2/command-docs/db/db-dump/#table-inclusion-and-exclusion

Seems that we need some additional logic and tests.

[martin-cod]

Hi @cmuench
It needs to be checked. Probably, not an issue.

I have 2 servers. On server1 I tried magerun2 version 9.0.2 and 9.1.0 and both commands misses part

mysqldump --single-transaction --quick --no-tablespaces --column-statistics=0 --no-data

On server2 both versions work correctly.

There is an issue with my server1 configuration, I guess. I do use the same .n98-magerun2.yaml file on both servers. It requires some further investigation

[martin-cod]

@cmuench I've updated the issue context, so it is a bit different now