Skip to content

Conversation

@sreichel
Copy link
Collaborator

@sreichel sreichel commented Nov 13, 2024

See ... #1326

  • added strict types
  • phpstan level 7
  • per-2 coding
  • use all rector rules
  • added checks to workflow
  • added Carbon for date funtions (not finished)

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

@sreichel sreichel changed the title Phpstan: push to level 3 Phpstan: push to level 4 Nov 13, 2024
@sreichel sreichel changed the title Phpstan: push to level 4 Phpstan: push to level 5 Nov 13, 2024
@sreichel sreichel force-pushed the phpstan branch 16 times, most recently from 5ab215e to 58887b7 Compare December 12, 2024 09:17
@sreichel sreichel changed the title Phpstan: push to level 5 Release v3 Dec 18, 2024
@sreichel sreichel marked this pull request as ready for review December 18, 2024 10:31
@sreichel
Copy link
Collaborator Author

@cmuench can you plese check phar-build, or should i revert phing to 2.7?

@cmuench
Copy link
Member

cmuench commented Dec 18, 2024

@cmuench can you plese check phar-build, or should i revert phing to 2.7?

I can try to backport the phar build process of n98-magerun2 where phing was replaced by box to build the phar file.

@cmuench
Copy link
Member

cmuench commented Dec 18, 2024

@sreichel I have backported the phar generation process but we need a rebase now.

# Conflicts:
#	composer.json
#	composer.lock
#	src/N98/Magento/Application.php
#	src/N98/Magento/Command/Config/GetCommand.php
#	src/N98/Magento/Command/Database/AbstractShowCommand.php
#	src/N98/Magento/Command/Developer/EmailTemplate/UsageCommand.php
#	src/N98/Magento/Command/Developer/Theme/InfoCommand.php
#	src/N98/Magento/Command/Script/Repository/ListCommand.php
@sreichel
Copy link
Collaborator Author

@cmuench nice.

I did not re-test every command manually, but everything i have tested works.

  • PHPstan 8/9 is mostly DOCblocks
  • using constants for commands and other cosmetic changes
  • use symfony filesystem, ...

... coming later.

@sreichel sreichel marked this pull request as draft December 25, 2024 23:59
@sreichel sreichel marked this pull request as ready for review January 1, 2025 17:44
@cmuench cmuench mentioned this pull request Feb 25, 2025
@sreichel
Copy link
Collaborator Author

@cmuench have you time to review?

@cmuench
Copy link
Member

cmuench commented Mar 14, 2025

@cmuench have you time to review?

Sorry, didn't recognize your push. Sadly I am traveling tomorrow to the Adobe Summit for a week.
IMHO we can merge to develop branch an then I can do the last checks there.

@sreichel
Copy link
Collaborator Author

Sadly I am traveling tomorrow to the Adobe Summit for a week.

Wanto change? 😄

@sreichel sreichel merged commit 930b4c0 into netz98:develop Mar 14, 2025
23 checks passed
@cmuench
Copy link
Member

cmuench commented Mar 23, 2025

Sadly I am traveling tomorrow to the Adobe Summit for a week.

Wanto change? 😄

I am back

@sreichel sreichel deleted the phpstan branch October 13, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants