refactor(lsp/rpc): move transport logic to separate module #31514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
refactor/transport
branch
3 times, most recently
from
509d5d5 to
b64007f
Compare
justinmk
reviewed
Dec 10, 2024
justinmk
reviewed
Dec 10, 2024
Member
|
This makes sense and maps to the layout in |
lewis6991
force-pushed
the
refactor/transport
branch
2 times, most recently
from
f8a31fe to
45968ad
Compare
lewis6991
force-pushed
the
refactor/transport
branch
from
45968ad to
f9aed77
Compare
justinmk
approved these changes
Dec 11, 2024
Member
justinmk
left a comment
justinmk
left a comment
There was a problem hiding this comment.
LGTM, but probably needs approval from someone who worked closely on this code
mfussenegger
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies
vim.lsp.rpc.start()andvim.lsp.rpc.connect()and puts them both into very similar forms.