Skip to content

Conversation

@hlinnaka
Copy link
Contributor

I think the handling of prepared transactions is broken in the page
server, so this is not passing.

@hlinnaka
Copy link
Contributor Author

@knizhnik, I was trying to understand the code you added to handle pg_twophase, and wrote the attached test case to see how it works. It doesn't. I guess that's a known issue?

If it's not working, can we remove all the half-baked code that tries to deal with it, maybe put it in a branch or something? I was trying to rebase #79, and it's hard to refactor things when I don't know what's supposed to work and what's not.

@knizhnik
Copy link
Contributor

Sorry, 2pc support was not completed yet. I have made some fixes but have not committed them yet.
I am now trying complete approach with starting compute node without sending and replaying WAL to it.
All tests are passed except test_branch_behind. But this is actually the only test where postgres is working with datadir created from page store. So I am in process of debugging.

@kelvich kelvich mentioned this pull request May 20, 2021
@hlinnaka hlinnaka changed the title WIP: Add test for prepared transactions. Add test for prepared transactions. May 24, 2021
@hlinnaka
Copy link
Contributor Author

I pushed PR #173, so this is passing now. I'll let the CI run through it one last time, and will push.

@hlinnaka hlinnaka merged commit e8f0a9b into main May 25, 2021
@hlinnaka hlinnaka deleted the test-twophase branch May 25, 2021 08:11
VladLazar pushed a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants