Have TranslatableContents throw when fed improper arguments in dev #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes neoforged#703 Also fixed several spots in NeoForge where we were passing bad arguments as well. Note: the track command's crash from bad argument passed to Translatable will be fixed in this PR: neoforged#915
|
Matyrobbrt
added
1.20.6
Matyrobbrt
reviewed
May 4, 2024
patches/net/minecraft/network/chat/contents/TranslatableContents.java.patch
Outdated
Show resolved
Hide resolved
Matyrobbrt
approved these changes
May 4, 2024
marchermans
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #703
The dev exception will look like this which is a bit more clearer than vanilla's error. And by having the throw in the constructor for TranslatableContent, it makes it easy to find the code that is the source of the problem.
Also fixed several spots in NeoForge where we were passing bad arguments as well.
Note: the track command's crash from bad argument passed to Translatable will be fixed in this PR: #915