Skip to content

Add support to pickling DateTime #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robsdedude merged 5 commits into from
Dec 20, 2023
Merged

Add support to pickling DateTime #1002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8274c24
formating
Tanguy-Boisset Dec 7, 2023
f26b236
Overhaul (deep)copy and pickle support for temporal and spatial types
robsdedude Dec 18, 2023
66a4c07
Merge branch '5.0' into tmp-5.0
robsdedude Dec 18, 2023
a445a00
Merge branch '5.0' into 5.0
robsdedude Dec 18, 2023
43bc1e7
Clean-up comments
robsdedude Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/neo4j/time/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2019,6 +2019,12 @@ def __new__(
return cls.combine(Date(year, month, day),
Time(hour, minute, second, nanosecond, tzinfo))

# SERIALIZATION #

def __reduce__(cls):
return (cls.__class__,
(cls.year, cls.month, cls.day, cls.hour, cls.minute, cls.second, cls.nanosecond, cls.tzinfo))

# CLASS METHODS #

@classmethod
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/common/time/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import copy
import itertools
import operator
import pickle
from datetime import (
datetime,
timedelta,
Expand Down Expand Up @@ -410,6 +411,11 @@ def test_datetime_deep_copy(self) -> None:
assert d is not d2
assert d == d2

def test_datetime_pickle(self) -> None:
expected = DateTime(2023, 12, 7, 12, 34, 56, 7890)
actual = pickle.loads(pickle.dumps(expected))
assert expected == actual


def test_iso_format_with_time_zone_case_1() -> None:
# python -m pytest tests/unit/time/test_datetime.py -s -v -k test_iso_format_with_time_zone_case_1
Expand Down