Introduce Bookmark Manager #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…okmark only updating the relevant bookmarks
…t return bookmarks
bigmontz
force-pushed
the
5.0-bookmark-manager
branch
from
ad8a5f3 to
b0ea446
Compare
fbiville
reviewed
Aug 8, 2022
robsdedude
approved these changes
Aug 8, 2022
Contributor
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
The test cases are sound. Maybe we could add an additional tests with explicitly configuring a BM that's already tracked by the BMM + an OPT_ feature flag that the driver can provide. With the flag, we assert that no duplicated bm is sent; without the flag we assert that the set of sent bookmarks matches what we expect.
I left a lot of comments. None of them is a real blocker.
tests/stub/driver_parameters/scripts/router_with_db_name.script
Outdated
Show resolved
Hide resolved
tests/stub/driver_parameters/scripts/transaction_chaining.script
Outdated
Show resolved
Hide resolved
Co-authored-by: Robsdedude <[email protected]>
robsdedude
reviewed
Aug 8, 2022
robsdedude
approved these changes
Aug 8, 2022
tests/stub/driver_parameters/scripts/router_with_db_name.script
Outdated
Show resolved
Hide resolved
Co-authored-by: Robsdedude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.