element id tests #408
Merged
element id tests #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Official drivers will not support 4.0, even with the extended 5.0 handshake. Tests requiring 4.0 are either: - removed (when variants for other 4.x are defined) - changed so that they require 4.4 (since 4.4 is the lowest 4.x version official drivers MUST support - other 4.x are optional)
don't know why this is on this branch
thelonelyvulpes
force-pushed
the
feature/element-id-changes
branch
from
257c25e to
e9e5f1d
Compare
thelonelyvulpes
requested review from
AndyHeap-NeoTech,
bigmontz,
injectives and
robsdedude
bigmontz
force-pushed
the
5.0_handshake
branch
2 times, most recently
from
169cdec to
fde638a
Compare
robsdedude
force-pushed
the
feature/element-id-changes
branch
from
0e1a7e9 to
c59877a
Compare
… feature/element-id-changes # Conflicts: # tests/stub/basic_query/test_basic_query.py
This reverts commit 7c733ba.
I.e., those without the new style element IDs. This change can be undone once all official drivers have implemented the new TestKit protocol.
Contributor
Author
|
dotnet failing because there's no implementation of CypherPath on testbackend in 5.0, this is fixed in the element id pr. |
robsdedude
approved these changes
Mar 9, 2022
Contributor
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
Ok now, from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented tests for all data structures surrounding element id.