-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade sass from 1.56.1 to 1.92.0 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade sass from 1.56.1 to 1.92.0. See this package in npm: sass See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/fc0f3580-80b8-41dd-b691-b9002cac83fe?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades sass from 1.56.1 to 1.92.0, a jump of 94 versions. This is a significant update that includes breaking changes. The most critical one is the change in how division is handled. Starting from Sass 1.58.0, / is treated as a separator, and math.div() must be used for division. Your project uses bulma version ^0.9.4, which still uses / for division. This will likely cause your build to fail. To resolve this, you should consider upgrading bulma to a version compatible with modern Sass (like 1.0.0), or pinning sass to a version before this breaking change. Additionally, the new version of sass raises the minimum required Node.js version to >=14.0.0. Please test the build and styling thoroughly after this upgrade.
| "redux-saga": "^1.1.3", | ||
| "redux-thunk": "^2.3.0", | ||
| "sass": "^1.56.1" | ||
| "sass": "^1.92.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade of sass from 1.56.1 to 1.92.0 introduces a significant breaking change. Starting from version 1.58.0, sass treats / as a separator, not a division operator. For division, math.div() must be used.
Your project uses bulma@^0.9.4, which still relies on / for division in its source files. This will likely cause your build to fail.
To fix this, you should consider one of the following:
- Upgrade
bulmato a version compatible with modern Sass (e.g.,1.0.0or newer). - If upgrading
bulmais not immediately possible, pinsassto a version before this breaking change, for example~1.57.0.
Thorough testing of your application's styling is highly recommended after this change.
| }, | ||
| "engines": { | ||
| "node": ">=12.0.0" | ||
| "node": ">=14.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snyk has created this PR to upgrade sass from 1.56.1 to 1.92.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 94 versions ahead of your current version.
The recommended version was released 22 days ago.
Release notes
Package name: sass
-
1.92.0 - 2025-09-02
-
1.91.0 - 2025-08-25
-
1.90.0 - 2025-08-05
-
1.89.2 - 2025-06-09
-
1.89.1 - 2025-05-30
-
1.89.0 - 2025-05-16
-
1.88.0 - 2025-05-10
-
1.87.0 - 2025-04-21
-
1.86.3 - 2025-04-04
-
1.86.2 - 2025-04-02
-
1.86.1 - 2025-03-31
-
1.86.0 - 2025-03-17
-
1.85.1 - 2025-02-25
-
1.85.0 - 2025-02-14
-
1.84.0 - 2025-02-06
-
1.83.4 - 2025-01-14
-
1.83.3 - 2025-01-14
-
1.83.2 - 2025-01-14
-
1.83.1 - 2025-01-04
-
1.83.0 - 2024-12-12
-
1.82.0 - 2024-12-03
-
1.81.1 - 2024-12-03
-
1.81.0 - 2024-11-15
-
1.80.7 - 2024-11-12
-
1.80.6 - 2024-11-01
-
1.80.5 - 2024-10-29
-
1.80.4 - 2024-10-23
-
1.80.3 - 2024-10-18
-
1.80.2 - 2024-10-17
-
1.80.1 - 2024-10-17
-
1.80.0 - 2024-10-17
-
1.79.6 - 2024-10-16
-
1.79.5 - 2024-10-11
-
1.79.4 - 2024-09-28
-
1.79.3 - 2024-09-20
-
1.79.2 - 2024-09-19
-
1.79.1 - 2024-09-18
-
1.79.0 - 2024-09-17
-
1.78.0 - 2024-09-03
-
1.77.8 - 2024-07-11
-
1.77.7 - 2024-07-09
-
1.77.6 - 2024-06-17
-
1.77.5 - 2024-06-11
-
1.77.4 - 2024-05-30
-
1.77.3 - 2024-05-29
-
1.77.2 - 2024-05-16
-
1.77.1 - 2024-05-10
-
1.77.0 - 2024-05-07
-
1.76.0 - 2024-04-30
-
1.75.0 - 2024-04-11
-
1.74.1 - 2024-04-04
-
1.72.0 - 2024-03-13
-
1.71.1 - 2024-02-21
-
1.71.0 - 2024-02-16
-
1.70.0 - 2024-01-18
-
1.69.7 - 2024-01-02
-
1.69.6 - 2023-12-28
-
1.69.5 - 2023-10-26
-
1.69.4 - 2023-10-17
-
1.69.3 - 2023-10-12
-
1.69.2 - 2023-10-10
-
1.69.1 - 2023-10-09
-
1.69.0 - 2023-10-05
-
1.68.0 - 2023-09-21
-
1.67.0 - 2023-09-14
-
1.66.1 - 2023-08-18
-
1.66.0 - 2023-08-17
-
1.65.1 - 2023-08-09
-
1.65.0 - 2023-08-09
-
1.64.2 - 2023-07-31
-
1.64.1 - 2023-07-22
-
1.64.0 - 2023-07-20
-
1.63.6 - 2023-06-21
-
1.63.5 - 2023-06-21
-
1.63.4 - 2023-06-14
-
1.63.3 - 2023-06-09
-
1.63.2 - 2023-06-08
-
1.63.1 - 2023-06-08
-
1.63.0 - 2023-06-07
-
1.62.1 - 2023-04-25
-
1.62.0 - 2023-04-11
-
1.61.0 - 2023-04-06
-
1.60.0 - 2023-03-23
-
1.59.3 - 2023-03-14
-
1.59.2 - 2023-03-11
-
1.59.1 - 2023-03-10
-
1.59.0 - 2023-03-10
-
1.58.3 - 2023-02-18
-
1.58.2 - 2023-02-17
-
1.58.1 - 2023-02-14
-
1.58.0 - 2023-02-01
-
1.57.1 - 2022-12-19
-
1.57.0 - 2022-12-17
-
1.56.2 - 2022-12-08
-
1.56.1 - 2022-11-09
from sass GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: