-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade sass from 1.56.1 to 1.91.0 #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade sass from 1.56.1 to 1.91.0. See this package in npm: sass See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/ef7b9ce7-cc9d-45d4-ba50-68028a01e13a?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated dependency upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the sass dependency from 1.56.1 to 1.91.0. This is a significant update, spanning 93 versions. While this is a minor version bump and should be backward-compatible, it's important to be aware of some key changes. Notably, sass versions 1.70.0 and later formally deprecate the @import rule in favor of @use. As your project uses @import to include Bulma, you will likely start seeing deprecation warnings in your build process after this merge. I've added a comment with more details and recommendations. Additionally, this update raises the required Node.js version for sass to >=14.0.0, which is compatible with your project's requirement of >=18.0.0. It also updates the transitive dependency immutable to a new major version (v5), but this should be handled by the sass package itself. It is recommended to test the application thoroughly after this upgrade.
| "node_modules/sass": { | ||
| "version": "1.56.1", | ||
| "resolved": "https://registry.npmjs.org/sass/-/sass-1.56.1.tgz", | ||
| "integrity": "sha512-VpEyKpyBPCxE7qGDtOcdJ6fFbcpOM+Emu7uZLxVrkX8KVU/Dp5UF7WLvzqRuUhB6mqqQt1xffLoG+AndxTZrCQ==", | ||
| "version": "1.91.0", | ||
| "resolved": "https://registry.npmjs.org/sass/-/sass-1.91.0.tgz", | ||
| "integrity": "sha512-aFOZHGf+ur+bp1bCHZ+u8otKGh77ZtmFyXDo4tlYvT7PWql41Kwd8wdkPqhhT+h2879IVblcHFglIMofsFd1EA==", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "chokidar": ">=3.0.0 <4.0.0", | ||
| "immutable": "^4.0.0", | ||
| "chokidar": "^4.0.0", | ||
| "immutable": "^5.0.2", | ||
| "source-map-js": ">=0.6.2 <2.0.0" | ||
| }, | ||
| "bin": { | ||
| "sass": "sass.js" | ||
| }, | ||
| "engines": { | ||
| "node": ">=12.0.0" | ||
| "node": ">=14.0.0" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@parcel/watcher": "^2.4.1" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to sass v1.91.0 is significant. One of the most important changes introduced since the version you were on (1.56.1) is the formal deprecation of the @import rule, which started with sass v1.70.0.
Your SCSS files (e.g., react-app/src/styles.scss, angular-app/src/styles.scss, etc.) use @import 'bulma/bulma.sass';. After this upgrade, you will likely start seeing deprecation warnings during your build.
While @import will continue to work for now, it will be removed in a future major version of Sass (2.0.0). It is highly recommended to migrate from @import to the newer @use rule to ensure future compatibility and to align with modern Sass best practices. The @use rule offers better encapsulation and performance.
For example, you would change:
@import 'bulma/bulma.sass';
to:
@use 'bulma/bulma.sass';
You can read more about this change and how to migrate in the official Sass documentation:
@userule: https://sass-lang.com/documentation/at-rules/use- Migrating from
@import: https://sass-lang.com/documentation/at-rules/import
Snyk has created this PR to upgrade sass from 1.56.1 to 1.91.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 93 versions ahead of your current version.
The recommended version was released a month ago.
Release notes
Package name: sass
-
1.91.0 - 2025-08-25
-
1.90.0 - 2025-08-05
-
1.89.2 - 2025-06-09
-
1.89.1 - 2025-05-30
-
1.89.0 - 2025-05-16
-
1.88.0 - 2025-05-10
-
1.87.0 - 2025-04-21
-
1.86.3 - 2025-04-04
-
1.86.2 - 2025-04-02
-
1.86.1 - 2025-03-31
-
1.86.0 - 2025-03-17
-
1.85.1 - 2025-02-25
-
1.85.0 - 2025-02-14
-
1.84.0 - 2025-02-06
-
1.83.4 - 2025-01-14
-
1.83.3 - 2025-01-14
-
1.83.2 - 2025-01-14
-
1.83.1 - 2025-01-04
-
1.83.0 - 2024-12-12
-
1.82.0 - 2024-12-03
-
1.81.1 - 2024-12-03
-
1.81.0 - 2024-11-15
-
1.80.7 - 2024-11-12
-
1.80.6 - 2024-11-01
-
1.80.5 - 2024-10-29
-
1.80.4 - 2024-10-23
-
1.80.3 - 2024-10-18
-
1.80.2 - 2024-10-17
-
1.80.1 - 2024-10-17
-
1.80.0 - 2024-10-17
-
1.79.6 - 2024-10-16
-
1.79.5 - 2024-10-11
-
1.79.4 - 2024-09-28
-
1.79.3 - 2024-09-20
-
1.79.2 - 2024-09-19
-
1.79.1 - 2024-09-18
-
1.79.0 - 2024-09-17
-
1.78.0 - 2024-09-03
-
1.77.8 - 2024-07-11
-
1.77.7 - 2024-07-09
-
1.77.6 - 2024-06-17
-
1.77.5 - 2024-06-11
-
1.77.4 - 2024-05-30
-
1.77.3 - 2024-05-29
-
1.77.2 - 2024-05-16
-
1.77.1 - 2024-05-10
-
1.77.0 - 2024-05-07
-
1.76.0 - 2024-04-30
-
1.75.0 - 2024-04-11
-
1.74.1 - 2024-04-04
-
1.72.0 - 2024-03-13
-
1.71.1 - 2024-02-21
-
1.71.0 - 2024-02-16
-
1.70.0 - 2024-01-18
-
1.69.7 - 2024-01-02
-
1.69.6 - 2023-12-28
-
1.69.5 - 2023-10-26
-
1.69.4 - 2023-10-17
-
1.69.3 - 2023-10-12
-
1.69.2 - 2023-10-10
-
1.69.1 - 2023-10-09
-
1.69.0 - 2023-10-05
-
1.68.0 - 2023-09-21
-
1.67.0 - 2023-09-14
-
1.66.1 - 2023-08-18
-
1.66.0 - 2023-08-17
-
1.65.1 - 2023-08-09
-
1.65.0 - 2023-08-09
-
1.64.2 - 2023-07-31
-
1.64.1 - 2023-07-22
-
1.64.0 - 2023-07-20
-
1.63.6 - 2023-06-21
-
1.63.5 - 2023-06-21
-
1.63.4 - 2023-06-14
-
1.63.3 - 2023-06-09
-
1.63.2 - 2023-06-08
-
1.63.1 - 2023-06-08
-
1.63.0 - 2023-06-07
-
1.62.1 - 2023-04-25
-
1.62.0 - 2023-04-11
-
1.61.0 - 2023-04-06
-
1.60.0 - 2023-03-23
-
1.59.3 - 2023-03-14
-
1.59.2 - 2023-03-11
-
1.59.1 - 2023-03-10
-
1.59.0 - 2023-03-10
-
1.58.3 - 2023-02-18
-
1.58.2 - 2023-02-17
-
1.58.1 - 2023-02-14
-
1.58.0 - 2023-02-01
-
1.57.1 - 2022-12-19
-
1.57.0 - 2022-12-17
-
1.56.2 - 2022-12-08
-
1.56.1 - 2022-11-09
from sass GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: