Skip to content

Fix colored logging #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Fix colored logging #2489

merged 2 commits into from
Apr 2, 2025

Conversation

filipmacek
Copy link
Member

Pull Request

  • color was not showing because key value store was empty for default logging, so we should get the color from log level instead (it was defaulting to Normal, which is without color or grey)

@filipmacek filipmacek added the bug Something isn't working label Apr 2, 2025
@filipmacek filipmacek requested a review from cjdsellers April 2, 2025 09:59
@filipmacek filipmacek self-assigned this Apr 2, 2025
@filipmacek filipmacek force-pushed the fix-colored-logging branch from 0f9e2c9 to 1fd773b Compare April 2, 2025 09:59
@cjdsellers cjdsellers merged commit 9e529f7 into develop Apr 2, 2025
12 checks passed
@cjdsellers cjdsellers deleted the fix-colored-logging branch April 2, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers Awaiting requested review from cjdsellers

Assignees

@filipmacek filipmacek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipmacek @cjdsellers