Skip to content

Port generate account state for SimulatedExchange in Rust #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

Port generate account state for SimulatedExchange in Rust #2272

merged 3 commits into from
Jan 30, 2025

Conversation

filipmacek
Copy link
Member

Pull Request

  • implemented account initialization and added missing starting balances for SimulatedExchange
  • tested that proper AccountState event is emitted on Portfolio.update_account endpoint
  • added constructor for ExecutionClient
  • added zero constructor for Money type

@filipmacek filipmacek added the rust Relating to the Rust core label Jan 30, 2025
@filipmacek filipmacek requested a review from cjdsellers January 30, 2025 22:02
@filipmacek filipmacek self-assigned this Jan 30, 2025
@cjdsellers cjdsellers changed the title Port generate fresh account state function for SimulatedExchange in Rust Port generate account state for SimulatedExchange in Rust Jan 30, 2025
cjdsellers
cjdsellers approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cjdsellers cjdsellers merged commit 0f70d49 into develop Jan 30, 2025
13 checks passed
@cjdsellers cjdsellers deleted the simulated-exchange-accounting branch January 30, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers cjdsellers approved these changes

Assignees

@filipmacek filipmacek

Labels
rust Relating to the Rust core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipmacek @cjdsellers