Move model crate stubs into defaults #2235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
If a rust project depends on
nautilus_model
crate, the project only compiles by including the "stubs" feature.This is due to the
Default
trait impls being included in the production execution path, while also being gated behind the "stubs" feature.The minimal repro for this is building a rust project with the
nautilus-model
crate as a single dependency.I've provided a fix that moves the trait impls into either of these locations:
derive(Default)
unwrap_or_default()
Type of change
Delete options that are not relevant.
How has this change been tested?
Test 1:
cargo build
in a rust Project that depends on cratenautilus_model
compiles successfully with no additional features.Test 2:
make install-debug
builds successfully.