Skip to content

Add execution.fast support for Bybit #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

sunlei
Copy link
Collaborator

@sunlei sunlei commented Jan 2, 2025

Pull Request

Add execution.fast support for Bybit.

There are fewer order fill events, so there isn’t enough data for a highly accurate comparison.
However, based on the limited sample size available, execution.fast is approximately 6% faster than execution.

Type of change

  • New feature (non-breaking change which adds functionality)

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #2165 will degrade performances by 44.55%

Comparing sunlei/bybit-execution-fast (6e4afd5) with develop (90563d7)

Summary

❌ 1 regressions
✅ 52 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop sunlei/bybit-execution-fast Change
test_condition_none 12.2 µs 21.9 µs -44.55%

@cjdsellers cjdsellers merged commit 280dac6 into develop Jan 2, 2025
17 checks passed
@cjdsellers cjdsellers deleted the sunlei/bybit-execution-fast branch January 2, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants