Skip to content

Refine margin balance report for dYdX #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

davidsblom
Copy link
Member

Pull Request

Refine margin balance report for dYdX

How has this change been tested?

Live example and existing unit tests

Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #2154 will degrade performances by 37.12%

Comparing dydx-margin-balance (57d14a2) with develop (c216bd4)

Summary

❌ 1 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop dydx-margin-balance Change
test_is_limit_filled 16.1 µs 25.6 µs -37.12%

@cjdsellers cjdsellers merged commit 1b6d357 into develop Dec 30, 2024
16 checks passed
@cjdsellers cjdsellers deleted the dydx-margin-balance branch December 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants