Skip to content

Handle directory and live streams to catalog #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

limx0
Copy link
Collaborator

@limx0 limx0 commented Dec 30, 2024

Pull Request

Update convert_stream_to_data to allow converting live data and dir structure data types (trade_tick, orderbook_deltas).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

Test added.

Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #2153 will degrade performances by 36.92%

Comparing feat/convert_stream_to_data (ef5ce9a) with develop (b8b00ea)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 50 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop feat/convert_stream_to_data Change
test_order_denied_to_dict 42.2 µs 33.4 µs +26.4%
test_is_limit_filled 16.2 µs 25.7 µs -36.92%

@cjdsellers cjdsellers merged commit 74c39a2 into develop Dec 30, 2024
16 checks passed
@cjdsellers cjdsellers deleted the feat/convert_stream_to_data branch December 30, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants