Skip to content

Fix demo notebook backtest_high_level #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Fix demo notebook backtest_high_level #2142

merged 1 commit into from
Dec 25, 2024

Conversation

stefansimik
Copy link
Contributor

Getting started notebook backtest_high_level.ipynbneeded some small updates in phase of loading data, because it was failing on some warning / errors as reported Discord: https://discord.com/channels/924497682343550976/924499913386102834/1321253768855162963

Notebook needed some small updates in phase of loading data, because it was failing on some warning / errors as reported Discord: https://discord.com/channels/924497682343550976/924499913386102834/1321253768855162963
@stefansimik
Copy link
Contributor Author

stefansimik commented Dec 25, 2024

Sending HTML export of the fixed notebook to show, it is really working.

backtest_high_level.html.zip

To easily reproduce the notebook, I am attaching also underlying CSV quote-tick data (downloaded from histdata.com), that were used for testing the notebook. Just put these *.csv files into: ~/Downloads/Data/ folder and the notebook will run without any error:

CSV files.zip

Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #2142 will improve performances by 51.84%

Comparing stefansimik:develop (473d25b) with develop (c6d0686)

Summary

⚡ 1 improvements
✅ 51 untouched benchmarks

Benchmarks breakdown

Benchmark develop stefansimik:develop Change
test_nautilus_convert_to_snake_case 26.9 µs 17.7 µs +51.84%

@cjdsellers cjdsellers changed the title Fixed demo notebook: backtest_high_level.ipynb (#2141) Fix demo notebook backtest_high_level (#2141) Dec 25, 2024
@cjdsellers cjdsellers changed the title Fix demo notebook backtest_high_level (#2141) Fix demo notebook backtest_high_level Dec 25, 2024
@cjdsellers
Copy link
Member

Many thanks! @stefansimik

Closes #2141

@cjdsellers cjdsellers merged commit fee0c5d into nautechsystems:develop Dec 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants