Skip to content

Conversation

@nathanbabcock
Copy link
Owner

No description provided.

@nathanbabcock nathanbabcock requested a review from Copilot July 27, 2025 20:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by updating dependencies and applying Rust clippy lints for cleaner, more idiomatic code. The changes include upgrading from Rust 1.79 to 1.88, updating dependency versions, and applying various clippy suggestions.

  • Updated Rust toolchain from 1.79 to 1.88
  • Updated dependencies: anyhow (1.0.79 → 1.0.98), ureq (2.10.1 → 3.0.12), tar (0.4.42 → 0.4.44), zip (2.3.0 → 4.3.0), nix (0.29.0 → 0.30.1)
  • Applied clippy suggestions to improve code style and performance

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rust-toolchain Updated Rust toolchain version from 1.79 to 1.88
Cargo.toml Updated dependency versions and zip package configuration
src/test.rs Replaced assert! equality checks with assert_eq!, updated format strings and method calls
src/read_until_any.rs Replaced any() iterator with contains() method for better performance
src/log_parser.rs Applied string interpolation, method call improvements, and test assertion updates
src/iter.rs Updated format string to use string interpolation
src/download.rs Updated HTTP response handling for ureq v3, applied string interpolation
src/command.rs Applied string interpolation to format strings
examples/*.rs Applied string interpolation and assert_eq! updates across examples
Comments suppressed due to low confidence (1)

rust-toolchain:8

  • Rust 1.88 does not exist. The latest stable Rust version as of my knowledge cutoff is 1.83. This version should be corrected to an existing stable version.
channel = "1.88"  # Avoid specifying a patch version here; see https://github.com/emilk/eframe_template/issues/145

@nathanbabcock nathanbabcock merged commit 034368c into main Aug 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants