emit audio progress events #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: audio events will have
0for unsupported fields. Fixes #81This is a quick non-breaking fix, supporting parsing audio progress messages which have a slightly different format than video ones:
Video progress:
Audio progress:
Specifically audio progress omits
frame,fps, andqfields.The most thorough and typesafe fix will be to add a dedicated
AudioProgressevent type with those fields omitted. That would be a breaking change in conjunction with adding#[non_exhaustive]to support future added event types.cc @ashhhleyyy fyi