Skip to content

Conversation

pehamTom
Copy link
Collaborator

@pehamTom pehamTom commented Aug 28, 2024

Description

Due to a missing check in the propagation of errors, some Z-errors were propagated incorrectly

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@pehamTom pehamTom requested a review from lucasberent August 28, 2024 12:15
@pehamTom pehamTom self-assigned this Aug 28, 2024
@pehamTom pehamTom added the bug Something isn't working label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.7%. Comparing base (172a381) to head (f9d9baa).
Report is 112 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #272   +/-   ##
=====================================
  Coverage   82.6%   82.7%           
=====================================
  Files         46      46           
  Lines       3920    3978   +58     
  Branches     353     353           
=====================================
+ Hits        3241    3292   +51     
- Misses       679     686    +7     
Flag Coverage Δ *Carryforward flag
cpp 83.3% <ø> (ø) Carriedforward from 172a381
python 82.3% <100.0%> (+0.1%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/ft_stateprep/state_prep.py 72.1% <100.0%> (+0.4%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Really just a comment because I stumbled upon it: we shouldn't be relying on private properties of Qiskit (Bit._index).
This is subject to change and access to the index (via the public Bit.index) is actually deprecated since way before Qiskit 1.0.

@pehamTom
Copy link
Collaborator Author

I am currently refactoring code anyway since I am working on something new that overlaps a lot with the state prep functionality. Gonna get rid of those private accesses then.

@pehamTom pehamTom merged commit 2cb0351 into main Aug 28, 2024
24 checks passed
@pehamTom pehamTom deleted the fix-z-propagation branch August 28, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants