Fix small code bugs for FT Stateprep #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a code has a number of qubits that is a power of 2, then the assertion in `_generate_circ_with_bounded_gates` that makes sure the bitvector variables encoding the CNOT qubits act only on valid qubits erroneously asserts that control and target should be less than 0. This of course always returns `False`.
Computing (d-1)//2 as the maximum number of errors is incorrect for codes with even distance.
This reverts commit 5e2ccfc.
So far we assumed that we always want to have an error correction code and thus the maximum number of independent errors in the circuit was computed as (d-1)//2. But for an error detection code we allow d//2 independent errors. For this I introduced a flag `error_detection_code` in the `StatePrepCircuit` class so that the errors are computed correctly. Furthermore, if d=2 this flag is set automatically.
pehamTom
force-pushed
the
fix-small-code-bugs
branch
from
ad84eba to
c8213b8
Compare
|
Rebasing to main because the other PR might be awhile |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=====================================
Coverage 82.5% 82.5%
=====================================
Files 46 46
Lines 3985 3997 +12
Branches 362 362
=====================================
+ Hits 3288 3298 +10
- Misses 697 699 +2
*This pull request uses carry forward flags. Click here to find out more.
|
|
The patch coverage is incorrect due to the concurrent execution of processes. All new functionality is covered and the diff of the project does not change. |
lucasberent
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues with certain codes.
There was a bug when the code was defined over a number of qubits, which is an exact power of 2, leading to the optimal state prep circuit failing to be synthesized.
Another issue occurred when looking at d=2 codes, which cannot be used for error correction but only for error detection. I have added functionality to set whether one wants to create the circuit for error detection or error correction in the
StatePrepCircuitclass.Fixes #265
Checklist: