-
Notifications
You must be signed in to change notification settings - Fork 23
Minor fixes to FTSP #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Minor fixes to FTSP #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can only ignore Z-errors for d=3 codes.
Due to an incorrect condition in the main loop of the heuristic state preaparation method, the algorithm always ran until the size limit of the encompassing set has been reached.
The number of allowed errors now also depends on whether the code has the same distance for both types of errors.
One function call was not passed the `zero_state` flag so sometimes the wrong state was prepared.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=====================================
Coverage 82.7% 82.7%
=====================================
Files 29 29
Lines 3170 3170
Branches 190 190
=====================================
Hits 2623 2623
Misses 547 547
*This pull request uses carry forward flags. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed edgede case in heuristic state prep for codes with even distances.
Furthermore changed calculation of logical error rate to be calculated per qubit
Checklist: