Skip to content

Conversation

pehamTom
Copy link
Collaborator

@pehamTom pehamTom commented Jul 22, 2024

Description

Fixed edgede case in heuristic state prep for codes with even distances.
Furthermore changed calculation of logical error rate to be calculated per qubit

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

pehamTom added 30 commits June 13, 2024 12:30
We can only ignore Z-errors for d=3 codes.
Due to an incorrect condition in the main loop of the heuristic state preaparation method,
the algorithm always ran until the size limit of the encompassing set has been reached.
The number of allowed errors now also depends on whether the code has the same distance
for both types of errors.
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.7%. Comparing base (bc00666) to head (6ac26e6).
Report is 125 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #243   +/-   ##
=====================================
  Coverage   82.7%   82.7%           
=====================================
  Files         29      29           
  Lines       3170    3170           
  Branches     190     190           
=====================================
  Hits        2623    2623           
  Misses       547     547           
Flag Coverage Δ *Carryforward flag
cpp 80.2% <ø> (ø) Carriedforward from 40d3427
python 83.7% <100.0%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/ft_stateprep/simulation.py 85.5% <100.0%> (ø)
src/mqt/qecc/ft_stateprep/state_prep.py 75.7% <100.0%> (ø)

@pehamTom pehamTom merged commit 37d3a6e into main Jul 22, 2024
@pehamTom pehamTom deleted the ftsp branch July 22, 2024 12:21
@burgholzer burgholzer added the fix Fix for something that isn't working label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants