fix(output): export output writer #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Apr 4, 2023
1 task
aymanbagabas
force-pushed
the
readwriter
branch
2 times, most recently
from
8368526 to
0f89b9f
Compare
aymanbagabas
changed the title
aymanbagabas
force-pushed
the
readwriter
branch
from
0f89b9f to
272baeb
Compare
aymanbagabas
force-pushed
the
readwriter
branch
2 times, most recently
from
f96dbec to
efeeaef
Compare
caarlos0
approved these changes
May 15, 2023
caarlos0
added a commit
to charmbracelet/bubbletea
that referenced
this pull request
May 15, 2023
refs muesli/termenv#122 Signed-off-by: Carlos Alexandro Becker <[email protected]>
aymanbagabas
force-pushed
the
readwriter
branch
from
312c032 to
63dcd52
Compare
Termenv output can be a buffer, ssh session, a file, or anything that implements the io.Writer interface. In the case of an ssh session, the std ssh library returns a io.ReadWriter for ssh sessions and the current Termenv implementation makes it impossible to read terminal status reports since it expects a file in return. In addition, the TTY() function is confusing since it implies that the returned value is a TTY. Which is not always true until we check that using the isTTY() function. Deprecate TTY() in favor of Writer() which simply returns the underlying writer. The caller then can infer the type of the writer and decide what to do with it. This also deprecate parts of commit 669c9ab 669c9ab
aymanbagabas
force-pushed
the
readwriter
branch
from
63dcd52 to
30e443b
Compare
caarlos0
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Termenv output can be a buffer, ssh session, a file, or anything that
implements the io.Writer interface.
In the case of an ssh session, the std ssh library returns a
io.ReadWriter for ssh sessions and the current Termenv implementation
makes it impossible to read terminal status reports since it expects a
file in return.
In addition, the TTY() function is confusing since it implies that the
returned value is a TTY. Which is not always true until we check that
using the isTTY() function.
Deprecate TTY() in favor of Writer() which simply returns the underlying
writer. The caller then can infer the type of the writer and decide what
to do with it.
This also deprecates parts of commit 669c9ab 669c9ab