Skip to content

Commit 8580239

Browse files
authored
[EGD-4101] Temporary removed SMS memory setting. (#850)
Co-authored-by: Kuba Kleczkowski <dd>
1 parent 03ae32d commit 8580239

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
* `[messages]` SMS bubble edges smoothing.
2323
* `[phonebook]` Crash on contact details application exit fix.
2424
* `[specialInput]` Special characters inserts no longer call onBeforeShow.
25+
* `[cellular]` Temporary removed SMS memory setting.
2526

2627
## [0.42.1 2020-10-12]
2728

module-cellular/Modem/TS0710/TS0710.cpp

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -240,24 +240,8 @@ TS0710::ConfState TS0710::ConfProcedure()
240240
}
241241
}
242242

243-
bool timed_out = false;
244-
constexpr uint32_t cpmsTmeout = 5;
245-
const auto cpmsTmeoutTicks =
246-
cpp_freertos::Ticks::GetTicks() + pdMS_TO_TICKS(cpmsTmeout * utils::time::milisecondsInSecond);
247-
while (!timed_out) {
248-
if (parser->cmd(at::AT::SET_SMS_STORAGE)) {
249-
break;
250-
}
251-
vTaskDelay(pdMS_TO_TICKS(utils::time::milisecondsInSecond));
252-
timed_out = cpp_freertos::Ticks::GetTicks() > cpmsTmeoutTicks;
253-
if (timed_out) {
254-
return ConfState::Failure;
255-
}
256-
}
257-
258243
LOG_WARN("TODO: determine while this retry loop is necessary");
259-
260-
timed_out = false;
244+
bool timed_out = false;
261245
constexpr uint32_t qsclkTmeout = 30;
262246
const auto qsclkTmeoutTicks =
263247
cpp_freertos::Ticks::GetTicks() + pdMS_TO_TICKS(qsclkTmeout * utils::time::milisecondsInSecond);

0 commit comments

Comments
 (0)