[EGD-4079] List looping rebuild fix. Draft msg overwriting sms input text. Crush on contact details application exit fix. Special characters inserts no longer call onBeforeShow.

Author: PrzeBrudny

changelog.md

@@ -17,6 +17,11 @@
 * `[audio]` Fix parsing audio meta tags during playback
 * `[settings]` Removed the border around the settings menu.
 * `[simulator]` Fix crash on exit.
+* `[listview]` Looping rebuild fix.
+* `[messages]` Draft msg overwriting sms input text.
+* `[messages]` SMS bubble edges smoothing.
+* `[phonebook]` Crash on contact details application exit fix.
+* `[specialInput]` Special characters inserts no longer call onBeforeShow.
 
 ## [0.42.1 2020-10-12]
 

module-apps/Application.cpp

@@ -400,14 +400,16 @@ namespace app
             // check if this is case where application is returning to the last visible window.
             if ((switchData != nullptr) && (msg->LastSeenWindow)) {}
             else {
-                getCurrentWindow()->onBeforeShow(msg->getCommand(), switchData.get());
                 auto ret = dynamic_cast<gui::SwitchSpecialChar *>(switchData.get());
                 if (ret != nullptr && switchData != nullptr) {
                     auto text = dynamic_cast<gui::Text *>(getCurrentWindow()->getFocusItem());
                     if (text != nullptr) {
                         text->addText(ret->getDescription());
+                        refreshWindow(gui::RefreshModes::GUI_REFRESH_FAST);
+                        return msgHandled();
                     }
                 }
+                getCurrentWindow()->onBeforeShow(msg->getCommand(), switchData.get());
             }
             refreshWindow(gui::RefreshModes::GUI_REFRESH_DEEP);
         }

module-apps/application-messages/data/MessagesStyle.hpp

@@ -67,7 +67,7 @@ namespace style
 
         namespace smsOutput
         {
-            constexpr gui::Length sms_radius                   = 7;
+            constexpr gui::Length sms_radius                   = 8;
             constexpr gui::Length default_h                    = 30;
             constexpr gui::Length sms_max_width                = 320;
             constexpr gui::Length sms_h_padding                = 15;

module-apps/application-messages/models/SMSThreadModel.cpp

@@ -78,7 +78,7 @@ auto SMSThreadModel::handleQueryResponse(db::QueryResult *queryResult) -> bool
 
     resetInputWidget();
 
-    if (msgResponse->getDraft().isValid()) {
+    if (msgResponse->getDraft().isValid() && smsInput->inputText->isEmpty()) {
         smsInput->draft = msgResponse->getDraft().type == SMSType::DRAFT
                               ? std::optional<SMSRecord>{msgResponse->getDraft()}
                               : std::nullopt;

module-apps/application-phonebook/ApplicationPhonebook.cpp

@@ -96,11 +96,6 @@ namespace app
         return ret;
     }
 
-    auto ApplicationPhonebook::DeinitHandler() -> sys::ReturnCodes
-    {
-        return sys::ReturnCodes::Success;
-    }
-
     void ApplicationPhonebook::createUserInterface()
     {
         windowsFactory.attach(gui::name::window::main_window, [](Application *app, const std::string &name) {

module-apps/application-phonebook/ApplicationPhonebook.hpp

@@ -33,7 +33,6 @@ namespace app
 
         auto DataReceivedHandler(sys::DataMessage *msgl, sys::ResponseMessage *resp) -> sys::Message_t override;
         auto InitHandler() -> sys::ReturnCodes override;
-        auto DeinitHandler() -> sys::ReturnCodes override;
 
         auto SwitchPowerModeHandler(const sys::ServicePowerMode mode) -> sys::ReturnCodes final
         {

module-apps/application-phonebook/models/ContactDetailsModel.cpp

@@ -11,6 +11,12 @@
 ContactDetailsModel::ContactDetailsModel(app::Application *app) : application(app)
 {}
 
+void ContactDetailsModel::clearData()
+{
+    list->clear();
+    eraseInternalData();
+}
+
 auto ContactDetailsModel::requestRecordsCount() -> unsigned int
 {
     return internalData.size();
@@ -53,8 +59,7 @@ void ContactDetailsModel::createData(bool showInformationWidget, bool showAddres
 
 void ContactDetailsModel::loadData(std::shared_ptr<ContactRecord> contactRecord)
 {
-    list->clear();
-    eraseInternalData();
+    clearData();
 
     auto isInformationDataExist = [&]() -> bool {
         return contactRecord->numbers.size() > 0 || contactRecord->mail.length() > 0;

module-apps/application-phonebook/models/ContactDetailsModel.hpp

@@ -14,6 +14,7 @@ class ContactDetailsModel : public app::InternalModel<gui::ContactListItem *>, p
   public:
     ContactDetailsModel(app::Application *app);
 
+    void clearData();
     void loadData(std::shared_ptr<ContactRecord> contactRecord);
 
     [[nodiscard]] auto requestRecordsCount() -> unsigned int override;

module-apps/application-phonebook/windows/PhonebookContactDetails.cpp

@@ -43,6 +43,11 @@ namespace gui
         erase();
     }
 
+    void PhonebookContactDetails::onClose()
+    {
+        contactDetailsModel->clearData();
+    }
+
     PhonebookContactDetails::~PhonebookContactDetails()
     {
         destroyInterface();
@@ -128,5 +133,4 @@ namespace gui
 
         return false;
     }
-
 } // namespace gui

module-apps/application-phonebook/windows/PhonebookContactDetails.hpp

@@ -19,6 +19,7 @@ namespace gui
         auto onInput(const InputEvent &inputEvent) -> bool override;
         void onBeforeShow(ShowMode mode, SwitchData *data) override;
         auto handleSwitchData(SwitchData *data) -> bool override;
+        void onClose() override;
         void rebuild() override;
         void buildInterface() override;
         void destroyInterface() override;