fix: handle incomplete localStorage in Node.js v25
#2636
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
localStorage in Node.js v25
Member
It's not recommended for the same reason I stated it was experimental. Odd versions move faster, break more, and, as a result, gather more bugs to tackle before the next even release. That is why they are not recommended and why you are unlikely to find tooling that claims their support. But based on the discussion around, as weird as it is, it seems that Node.js will keep that way of treating web storages so libraries would have to dance around it. It's needless but an extra seems fine. |
Member
Released: v2.12.4 🎉This has been released in v2.12.4. Get these changes by running the following command: Predictable release automation by Release. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2624
Closes #2626
An alternative to #2626 that's a little more explicit and targets the Node.js v25 behaviour.
And re this comment in that thread:
This is not true, it's intended to be stable and perfectly usable and is supposed to be a good target for developers to use. Just not recommended for production deployments where stability is key.
Like a lot of devs, I use
currentandlts/*as targets in my GitHub actions, so this started coming up as a failure for us pretty quickly.