fix(toPublicUrl): remove search parameters in Node.js #2629
+88
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `toPublicUrl` more consistent among environments and prevent `onUnhandledRequest` from presenting a duplicated query string Also add node env test suites for `toPublicUrl` and `onUnhandledRequest` Refs: mswjs#2628
commit: |
kettanaito
approved these changes
Nov 23, 2025
Member
kettanaito
left a comment
kettanaito
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks, @Enet4.
kettanaito
changed the title
4 tasks
Member
Released: v2.12.3 🎉This has been released in v2.12.3. Get these changes by running the following command: Predictable release automation by Release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
toPublicUrlmore consistent among environments and preventonUnhandledRequestfrom presenting a duplicated query string.Also add node env test suites for
toPublicUrlandonUnhandledRequest.Refs: #2628
Addendum: there was a suggestion to change the behavior of
toPublicUrlso that it would include the search parameters everywhere, but this would have led to the breaking of multiple other assumptions from callers oftoPublicUrl, so this seemed to me like a reasonable path with much less friction.