Skip to content

fix(node): move browser and react-native export conditions lower #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kettanaito merged 1 commit into from
Nov 14, 2025
+2 −2
Merged

fix(node): move browser and react-native export conditions lower #2627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@
}
},
"./node": {
"browser": null,
"react-native": null,
"module-sync": {
"types": "./lib/node/index.d.mts",
"default": "./lib/node/index.mjs"
Expand All @@ -79,6 +77,8 @@
"types": "./lib/node/index.d.mts",
"default": "./lib/node/index.mjs"
},
"browser": null,
Copy link
Member

@kettanaito kettanaito Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just worried that some browser environments might false-positively match some of the preceding conditions, like module.

@markerikson, hi! Sorry for a direct ping. May I ask for your wisdom on this change? Do you see any unexpected behaviors this would cause for browsers importing the /node path?

Copy link

@markerikson markerikson Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure I've seen use of a null value for a condition before, but then again I also stopped trying to think about this after we got the RTK packages in shape :)

I don't have a good answer here, but looking at the issue thread it sounds like this helps. Worth a shot?

Copy link
Member

@kettanaito kettanaito Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate your input. I also no see any dangers with this, so release it is!

"react-native": null,
"default": {
"types": "./lib/node/index.d.ts",
"default": "./lib/node/index.js"
Expand Down
Loading