Skip to content

Conversation

@jbampton
Copy link
Contributor

@jbampton jbampton commented May 2, 2025

https://github.com/rhysd/actionlint

Used to lint GitHub Actions workflow files

refs mruby/mruby#6360

@jbampton jbampton requested a review from matz as a code owner May 2, 2025 16:19
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds actionlint to the pre-commit hooks. actionlint is a linter for GitHub Actions workflow files. The goal is to improve the quality and consistency of the workflow files by automatically checking for common errors and style issues.

Highlights

  • Integration of actionlint: The pull request introduces actionlint as a pre-commit hook to lint GitHub Actions workflow files.
  • Configuration: The .pre-commit-config.yaml file is modified to include the actionlint repository and hook.

Changelog

  • .pre-commit-config.yaml
    • Added a new repo entry for https://github.com/rhysd/actionlint.
    • Specified the revision v1.7.7 for actionlint.
    • Added a hook to run actionlint with the name 'run actionlint' and description 'lint GitHub Actions workflow files'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A linter's keen eye,
Finds errors that slip by,
Workflows now clean,
A smoother machine,
Code quality so high.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds actionlint to the pre-commit hooks, which is a great way to ensure the quality of GitHub Actions workflow files. The changes are straightforward and well-integrated.

Merge Readiness

The pull request is ready to be merged. The addition of actionlint is a valuable contribution to the project's code quality. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@matz matz merged commit 1c33a65 into mruby:master May 3, 2025
3 checks passed
@jbampton jbampton deleted the add-actionlint branch May 3, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants