Remove undefStack stuff in the cff parser #20537
Merged
+24
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/botio test |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c0fdf0f58e99778/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ce897cb25bcf9f2/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ce897cb25bcf9f2/output.txt Total script time: 40.87 mins
Image differences available at: http://54.241.84.105:8877/ce897cb25bcf9f2/reftest-analyzer.html#web=eq.log |
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c0fdf0f58e99778/output.txt Total script time: 80.40 mins
Image differences available at: http://54.193.163.58:8877/c0fdf0f58e99778/reftest-analyzer.html#web=eq.log |
I think it should have been removed with mozilla#2527 so it should be useless now. Because of that stuff, some commands with a wrong number of arguments weren't stripped out (see the pdf in mozilla#13850).
calixteman
force-pushed
the
remove_undestack
branch
from
1151beb to
1dffcf7
Compare
timvandermeij
approved these changes
Dec 28, 2025
Contributor
|
Thank you for cleaning this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should have been removed with #2527 so it should be useless now.
Because of that stuff, some commands with a wrong number of arguments
weren't stripped out (see the pdf in #13850).