Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions browser/config/mozconfigs/win64-aarch64/nightly-enterprise
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
. "$topsrcdir/build/mozconfig.win-common"
. "$topsrcdir/browser/config/mozconfigs/win64-aarch64/common-win64"
. "$topsrcdir/browser/config/mozconfigs/win64-aarch64/common-opt"

ac_add_options --enable-enterprise

. "$topsrcdir/build/mozconfig.common.override"
3 changes: 2 additions & 1 deletion python/mozbuild/mozbuild/mach_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -3062,7 +3062,7 @@ def repackage_msi(
@CommandArgument(
"--channel",
type=str,
choices=["official", "beta", "esr", "aurora", "nightly", "unofficial"],
choices=["official", "beta", "esr", "aurora", "nightly", "unofficial", "FirefoxEnterprise"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "enterprise" is more in-line with the other options, but this is firmly your call

help="Release channel.",
)
@CommandArgument(
Expand Down Expand Up @@ -3168,6 +3168,7 @@ def repackage_msix(
"beta": "beta",
"aurora": "aurora",
"nightly": "nightly",
"FirefoxEnterprise": "firefoxenterprise",
}

if not input:
Expand Down
1 change: 1 addition & 0 deletions python/mozbuild/mozbuild/repackaging/msix.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ def repackage_msix(
"aurora",
"nightly",
"unofficial",
"firefoxenterprise",
):
raise Exception(f"channel is unrecognized: {channel}")

Expand Down
2 changes: 2 additions & 0 deletions taskcluster/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ treeherder:
'Rpk-Ent': 'Enterprise repacks'
'Rpk': 'Classic repacks'
'MSI-Ent': "MSI Enterprise repacks"
'MSIX-Ent': "MSIX Enterprise repacks"
'MSIs-Ent': "MSI signed Enterprise repacks"
'MSIXs-Ent': "MSIX signed Enterprise repacks"
'BMS-Ent': "Mac signing for Enterprise repacks"
'BMN-Ent': "Mac notarization for Enterprise repacks"

Expand Down
16 changes: 12 additions & 4 deletions taskcluster/gecko_taskgraph/decision.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,17 @@
},
},
},
"repackage-msix": {
"sample": {
"gcpEU": {
"locales": ["en-US"],
"platforms": [
"win64-enterprise-shippable",
"win64-aarch64-enterprise-shippable",
],
},
},
},
"enterprise-repack-repackage": {
"sample": {
"gcpEU": {
Expand All @@ -151,6 +162,7 @@
"linux64-aarch64-enterprise-shippable",
"macosx64-enterprise-shippable",
"win64-enterprise-shippable",
"win64-aarch64-enterprise-shippable",
],
},
},
Expand All @@ -160,9 +172,7 @@
"gcpEU": {
"locales": ["en-US"],
"platforms": [
"linux64-enterprise-shippable",
"macosx64-enterprise-shippable",
"win64-enterprise-shippable",
],
},
},
Expand All @@ -172,8 +182,6 @@
"gcpEU": {
"locales": ["en-US"],
"platforms": [
"linux64-enterprise-shippable",
"macosx64-enterprise-shippable",
"win64-enterprise-shippable",
],
},
Expand Down
6 changes: 5 additions & 1 deletion taskcluster/gecko_taskgraph/transforms/partner_repack.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ def add_command_arguments(config, tasks):
task["attributes"]["build_platform"],
),
)
platform = task["attributes"]["build_platform"].partition("-shippable")[0]
platform = (
task["attributes"]["build_platform"]
.partition("-shippable")[0]
.partition("-enterprise")[0]
)
task["run"]["options"] = [
"version={}".format(release_config["version"]),
"build-number={}".format(release_config["build_number"]),
Expand Down
22 changes: 16 additions & 6 deletions taskcluster/gecko_taskgraph/transforms/repackage.py
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,17 @@ def make_job_description(config, jobs):
if not dep_th_platform and "enterprise-repack-repackage" in dep_job.kind:
build_platform = attributes.get("build_platform")
if "linux64" in build_platform:
dep_th_platform = "linux64-enterprise/opt"
if "aarch64" in build_platform:
dep_th_platform = "linux64-aarch64-enterprise/opt"
else:
dep_th_platform = "linux64-enterprise/opt"
elif "macosx64" in build_platform:
dep_th_platform = "osx-cross-enterprise/opt"
elif "win64" in build_platform:
dep_th_platform = "windows2012-64-enterprise/opt"
if "aarch64" in build_platform:
dep_th_platform = "windows2012-aarch64-enterprise/opt"
else:
dep_th_platform = "windows2012-64-enterprise/opt"
else:
raise ValueError(f"Unsupported {build_platform}")

Expand Down Expand Up @@ -567,10 +573,14 @@ def make_job_description(config, jobs):
elif config.kind == "repackage-msix":
assert not locale

# Like "MSIXs(Bs)".
treeherder["symbol"] = "MSIX({})".format(
dep_job.task.get("extra", {}).get("treeherder", {}).get("symbol", "B")
)
if "enterprise-repack" in dep_job.label:
repack_id = dep_job.task.get("extra").get("repack_id")
treeherder["symbol"] = f"MSIX-Ent({repack_id})"
else:
# Like "MSIXs(Bs)".
treeherder["symbol"] = "MSIX({})".format(
dep_job.task.get("extra", {}).get("treeherder", {}).get("symbol", "B")
)

elif config.kind == "repackage-shippable-l10n-msix":
assert not locale
Expand Down
10 changes: 8 additions & 2 deletions taskcluster/gecko_taskgraph/transforms/repackage_partner.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,17 @@ def make_job_description(config, jobs):
.replace("shippable", "")
)
if "linux64" in platform:
th_platform = "linux64-enterprise/opt"
if "aarch64" in platform:
th_platform = "linux64-aarch64-enterprise/opt"
else:
th_platform = "linux64-enterprise/opt"
elif "macosx64" in platform:
th_platform = "osx-cross-enterprise/opt"
elif "win64" in platform:
th_platform = "windows2012-64-enterprise/opt"
if "aarch64" in platform:
th_platform = "windows2012-aarch64-enterprise/opt"
else:
th_platform = "windows2012-64-enterprise/opt"
else:
raise ValueError(f"Unsupported {platform}")

Expand Down
13 changes: 12 additions & 1 deletion taskcluster/gecko_taskgraph/transforms/repackage_signing.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,18 @@ def make_repackage_signing_description(config, jobs):
dep_symbol = dep_job.task.get("extra").get("treeherder").get("symbol")
treeherder["symbol"] = f"MSIs-Ent({dep_symbol})"
else:
treeherder["symbol"] = "MSIs({})".format(locale or "N")
treeherder["symbol"] = "MSIs({})".format(
dep_job.task.get("extra", {}).get("treeherder", {}).get("symbol", "B")
)

if config.kind == "repackage-signing-msix":
if "enterprise-repack" in dep_job.label:
dep_symbol = dep_job.task.get("extra").get("treeherder").get("symbol")
treeherder["symbol"] = f"MSIXs-Ent({dep_symbol})"
else:
treeherder["symbol"] = "MSIXs({})".format(
dep_job.task.get("extra", {}).get("treeherder", {}).get("symbol", "B")
)

elif config.kind in (
"repackage-signing-msix",
Expand Down
1 change: 1 addition & 0 deletions taskcluster/kinds/beetmover-geckoview/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ not-for-build-platforms:
- win64-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-shippable/opt
- win64-aarch64-enterprise-shippable/opt
- win64-nightlyasrelease/opt
- linux64-devedition/opt
- linux64-aarch64-devedition/opt
Expand Down
55 changes: 55 additions & 0 deletions taskcluster/kinds/build/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,61 @@ win64-enterprise-shippable/opt:
fetch:
- upx-3.95-win

win64-aarch64-enterprise-shippable/opt:
description: "AArch64 Win64 Enterprise Shippable"
index:
product: firefox
job-name: win64-aarch64-enterprise-opt
type: shippable
attributes:
shippable: true
enable-full-crashsymbols: true
shipping-phase: build
shipping-product: firefox
treeherder:
platform: windows2012-aarch64-enterprise-shippable/opt
symbol: Bent
tier: 1
run-on-projects: ["enterprise-firefox"]
run-on-repo-type: ["git"]
worker-type: b-linux-docker-xlarge-amd
worker:
max-run-time: 10800
env:
PERFHERDER_EXTRA_OPTIONS: enterprise
MOZ_AUTOMATION_PACKAGE_TESTS: "1"
run:
actions: [get-secrets, build]
options: [append-env-variables-from-configs]
script: mozharness/scripts/fx_desktop_build.py
secrets: true
config:
- builds/releng_base_firefox.py
- builds/releng_base_linux_64_builds.py
extra-config:
stage_platform: win64-aarch64
mozconfig_platform: win64-aarch64
max_build_output_timeout: 3600
fetches:
toolchain:
- linux64-clang
- linux64-rust-cross
- linux64-rust-size
- linux64-nasm
- linux64-node
- linux64-cbindgen
- linux64-dump_syms
- linux64-wine
- linux64-winchecksec
- nsis
- sysroot-x86_64-linux-gnu
- sysroot-wasm32-wasi
- vs
- dxc-aarch64-pc-windows-msvc
- winappsdk-aarch64-pc-windows-msvc
fetch:
- upx-3.95-win

win64-plain/opt:
description: "Win64 Opt Plain"
index:
Expand Down
5 changes: 5 additions & 0 deletions taskcluster/kinds/enterprise-repack-repackage/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ kind-dependencies:
only-for-build-platforms:
- macosx64-enterprise-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-enterprise-shippable/opt

tasks:
enterprise-repack-repackage:
Expand All @@ -44,6 +45,10 @@ tasks:
- repackage/base.py
- repackage/win32_sfx_stub.py
- repackage/win64_partner.py
win64-aarch64\b.*:
- repackage/base.py
- repackage/win64-aarch64_sfx_stub.py
- repackage/win64_signed.py
linux64.*:
- repackage/base.py
package-formats:
Expand Down
10 changes: 10 additions & 0 deletions taskcluster/kinds/enterprise-repack/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ only-for-build-platforms:
- linux64-aarch64-enterprise-shippable/opt
- macosx64-enterprise-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-enterprise-shippable/opt

tasks:
linux64-enterprise-shippable:
Expand Down Expand Up @@ -91,3 +92,12 @@ tasks:
build_platform: win64-enterprise-shippable
build_type: opt
artifact_prefix: public
win64-aarch64-enterprise-shippable:
treeherder:
symbol: Rpk-Ent
platform: windows2012-aarch64-enterprise/opt
attributes:
shippable: true
build_platform: win64-aarch64-enterprise-shippable
build_type: opt
artifact_prefix: public
11 changes: 7 additions & 4 deletions taskcluster/kinds/repackage-msix/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ transforms:

kind-dependencies:
# We're going to generate tasks based on this. We `depend` on and fetch the package from this.
- enterprise-repack-repackage
- build-signing
- toolchain

task-defaults:
run-on-repo-type: [hg]

only-for-build-platforms:
- win32/opt
- win64/opt
- win64-aarch64/opt
- win64/debug
- win32-shippable/opt
- win64-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-shippable/opt
- win64-aarch64-enterprise-shippable/opt
- win32-devedition/opt
- win64-devedition/opt
- win64-aarch-devedition/opt
Expand All @@ -39,7 +39,7 @@ tasks:
worker:
max-run-time: 2700
# This is for fast try iteration; `repackage-shippable-l10n-msix` is the "real one".
run-on-projects: []
# run-on-projects: []
mozharness:
config:
by-build-platform:
Expand All @@ -66,6 +66,7 @@ tasks:
devedition: aurora
default:
by-release-type:
nightly-enterprise: FirefoxEnterprise
beta.*: beta
release.*: official
esr.*: official
Expand All @@ -80,12 +81,14 @@ tasks:
by-package-format:
msix:
by-release-type:
nightly-enterprise: FirefoxEnterprise
beta.*: MozillaFirefoxBeta
release.*: MozillaFirefox
esr.*: MozillaFirefox
default: MozillaFirefoxNightly
msix-store:
by-release-type:
nightly-enterprise: FirefoxEnterprise
beta.*: FirefoxBeta
release.*: Firefox
esr.*: Firefox
Expand Down
3 changes: 0 additions & 3 deletions taskcluster/kinds/repackage-signing-msix/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ transforms:
kind-dependencies:
- repackage-msix

task-defaults:
run-on-repo-type: [hg]

tasks:
repackage-signing-msix:
from-deps:
Expand Down
1 change: 1 addition & 0 deletions taskcluster/kinds/repackage-signing/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ only-for-build-platforms:
- win64-aarch64-devedition/opt
- win64-asan-reporter-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-enterprise-shippable/opt

tasks:
repackage-signing:
Expand Down
1 change: 1 addition & 0 deletions taskcluster/kinds/repackage/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ only-for-build-platforms:
- win64/opt
- win64-asan-reporter-shippable/opt
- win64-enterprise-shippable/opt
- win64-aarch64-enterprise-shippable/opt

tasks:
repackage:
Expand Down
Loading