Encrypt SQLite databases from mozStorageService #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp
requested changes
Nov 21, 2025
| } | ||
|
|
||
| nsresult GetKeyForFile(nsIFile* aFile, nsCString& keyString) { | ||
| nsAutoCString telemetryFilename; |
security/keystore/KeyStorage.sys.mjs
Outdated
| } | ||
|
|
||
| try { | ||
| pk11token.login(true); |
Contributor
There was a problem hiding this comment.
I guess we don't actually want this (force pp login dialog?), so this couldn't land without @beurdouche 's follow up patches.
Collaborator
Author
There was a problem hiding this comment.
Not on enterprise, no, but this wouldn't do anything here, because the token is already unlocked. I can remove it for this PR, but release needs some way to unlock the token once, for fetching the keys, and then possibly re-locking it once they are loaded.
Contributor
|
I think this wants tests as well. For Foxfooding we can deal with some flakyness but causing all SQLite databases to get corrupted will probably get old soon for the poor testers 😄 |
Not-Nik
force-pushed
the
sqlite-encryption
branch
from
4366c03 to
6c41571
Compare
Not-Nik
force-pushed
the
sqlite-encryption
branch
from
6c41571 to
904029f
Compare
Not-Nik
had a problem deploying
to
Credentials
GitHub Actions
Failure
Not-Nik
had a problem deploying
to
Credentials
GitHub Actions
Failure
Not-Nik
had a problem deploying
to
Credentials
GitHub Actions
Failure
Not-Nik
force-pushed
the
sqlite-encryption
branch
from
904029f to
8afd65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypt SQLite database whose connections are created in mozStorageService. Cloned and
ATTACHed connections are also affected. The mechanism is behind a newsecurity.storage.keystore.enabled. The keys for the connections are stored, encrypted by the SDR, in a newbikeshed/keystore.enc.