Skip to content

Conversation

@tonypark78
Copy link

Add white space indicators in the editor. adobe#1763

@Pomax
Copy link

Pomax commented Feb 27, 2017

@tonypark0403 a few things: this PR looks like it needs a rebase before it can be merged, but I'm also missing the linkback to the specific issue this addresses (the github issue that your push comment refers to is itself a closed PR, so that doesn't seem quite right). Also, can you update the title so that people looking at the /pulls list can immediately see what it's for?

"contributors_url": "https://api.github.com/repos/adobe/brackets/contributors?per_page={0}&page={1}",
"extension_listing_url": "",
"extension_registry": "https://s3.amazonaws.com/extend.brackets/registry.json",
"extension_url": "https://s3.amazonaws.com/extend.brackets/{0}/{0}-{1}.zip",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git checkout master src/config.json please

@@ -0,0 +1,8 @@
# EditorConfig.org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file

@@ -0,0 +1,27 @@
# Changelog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file


function loadPreferences() {
_preferences = PreferencesManager.getExtensionPrefs(preferencesID);
_preferences.definePreference("enabled", "boolean", defaultPreferences.enabled);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should ponder this--do we want this on by default? cc @flukeout

@@ -0,0 +1,76 @@
/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's convert this to a .css file and modify the code above that loads it. We dont' want to render LESS files in the browser.

@@ -0,0 +1,31 @@
/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a .css.tmpl file?

@tonypark78
Copy link
Author

I changed the branch name to be more clear so please delete this branch.

@Pomax
Copy link

Pomax commented Mar 6, 2017

There's only one person who can delete branches on your repository, and that's you: go to your own repository on github, and then click the "branches" tab. This lets you delete branches from your repository. Can you mention what the new PR number is in a comment so that github sets up a crosslink?

@Pomax Pomax closed this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants