Apply codemods for Next.js 16 #6369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the nextjs group with 4 updates in the / directory: [@next/env](https://github.com/vercel/next.js/tree/HEAD/packages/next-env), [@next/third-parties](https://github.com/vercel/next.js/tree/HEAD/packages/third-parties), [next](https://github.com/vercel/next.js) and [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next). Updates `@next/env` from 16.0.8 to 16.0.10 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v16.0.10/packages/next-env) Updates `@next/third-parties` from 15.5.4 to 16.0.10 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v16.0.10/packages/third-parties) Updates `next` from 15.5.9 to 16.0.10 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.9...v16.0.10) Updates `eslint-config-next` from 15.5.4 to 16.0.10 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v16.0.10/packages/eslint-config-next) --- updated-dependencies: - dependency-name: "@next/env" dependency-version: 16.0.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nextjs - dependency-name: "@next/third-parties" dependency-version: 16.0.10 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nextjs - dependency-name: next dependency-version: 16.0.10 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nextjs - dependency-name: eslint-config-next dependency-version: 16.0.10 dependency-type: direct:development update-type: version-update:semver-major dependency-group: nextjs ... Signed-off-by: dependabot[bot] <[email protected]>
I think some of our manual config got integrated into Next.js's default config. This commit organises the config and removes redundancies, while keeping all existing config.
With the fixed ESLint config, it turned out we were breaking a number of rules.
Vinnl
commented
Dec 23, 2025
| const hasExposures = breachesDataArray.length > 0; | ||
| const hasUnresolvedBreaches = tabSpecificExposures.length > 0; | ||
|
|
||
| const TabContentActionNeeded = () => { |
Collaborator
Author
There was a problem hiding this comment.
This file defined three components (TabContentActionNeeded, TabContentFixed, and getZeroStateIndicator - the latter for some reason not a component) inside another component, leading to them getting recreated on every render. The linter pointed this out.
Collaborator
Author
There was a problem hiding this comment.
I had an LLM figure out the "circular reference" error that ESLint threw, and it actually organised it quite neatly, grouping a few things together that belonged together but were separate. What I did was inspect the diff between the before and after, and check that everything that was removed from the before had a place in the after, and that all the additions also made sense.
kschelonka
reviewed
Dec 23, 2025
| ...compat.config({ | ||
| extends: ["next"], | ||
| }), | ||
| const estlingConfig = defineConfig([ |
Collaborator
There was a problem hiding this comment.
typo here, eslintConfig is probably intended
kschelonka
reviewed
Dec 23, 2025
| UserAnnouncementWithDetails[] | null | ||
| >(props.userAnnouncements); | ||
| useEffect(() => { | ||
| // TODO The `react-hooks` ESLint rules didn't apply correctly |
Collaborator
There was a problem hiding this comment.
Please write a ticket for this TODO so it doesn't get lost
kschelonka
reviewed
Dec 23, 2025
Collaborator
kschelonka
left a comment
kschelonka
left a comment
There was a problem hiding this comment.
I've read up on next based on your comments and I think I understand why the workarounds are done. Someone with next experience should sign off though.
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/nextjs-a2457717e1
branch
9 times, most recently
from
f4b1952 to
d3ad27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://nextjs.org/blog/next-16 and https://nextjs.org/blog/next-16-1
Apart from the codemode, I had to fix our ESLint config, which now had some kind of circular references but had gotten fairly messy anyway. All the same config should still be there, although some of it moved into Next's own packages. However, some of them (most notably react-hooks) apparently didn't cover all our code, so I had to fix a bunch of errors, or at least add exceptions for them for now - I left a comment when I did.
I split the changes from the codemod and the changes I had to do for ESLint into separate commits, so that might help during reviewing.
Note that this merges into #6366, though maybe it should just target
main🤔