Skip to content

Conversation

@Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Dec 18, 2025

As per @mansaj:

The v2 versions are used, I think the ymls with v1 can be safely deleted now.

@Vinnl Vinnl self-assigned this Dec 18, 2025

This comment was marked as resolved.

Copy link
Collaborator

@mansaj mansaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the v1 files are deleted and v2 files renamed to the v1 filename, right?

@kschelonka
Copy link
Collaborator

kschelonka commented Dec 18, 2025

As a follow-up, there's more dockerhub uploads in other jobs (like the cron prerelease) which can be removed. I have suggestions for using reusable workflows/actions to deduplicate as well, but was waiting until our retro on deployment in the new year to discuss more. I'm aligned with removing all dockerhub if you want to get started on it.

Copy link
Collaborator

@kschelonka kschelonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was premature, merging this will probably break 1-click deployment. Need to remove dockerhub from there

https://github.com/mozilla/blurts-server/blob/main/.github/workflows/production_deploy.yml#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants