Automatically unarchive channels that have been used before #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesbxf
reviewed
Sep 16, 2019
Contributor
milesbxf
left a comment
milesbxf
left a comment
There was a problem hiding this comment.
We've added linting and formatting to the PR check - you should be able to do a pip install black isort and run ./autoformat from the root (it's worth setting up support in your editor for these).
Linting was how I caught the duplicate function issue, so definitely useful already!
response/slack/client.py
Outdated
|
|
||
| raise SlackError(f"Channel '{name}' not found") | ||
|
|
||
| def unarchive_channel(self, channel_id): |
Contributor
There was a problem hiding this comment.
There is already an unarchive_channel function on line 143, which will override this
ChrisAnn
force-pushed
the
auto_unarchive
branch
4 times, most recently
from
645f1a6 to
9e530ff
Compare
Also run black on the file.
ChrisAnn
force-pushed
the
auto_unarchive
branch
2 times, most recently
from
601f0eb to
7fbacef
Compare
This handles the case of re-using an existing comms channel that may have previously been archived as we won't automatically join it on re-openning.
ChrisAnn
force-pushed
the
auto_unarchive
branch
2 times, most recently
from
ca0f62d to
21cbde2
Compare
ChrisAnn
force-pushed
the
auto_unarchive
branch
from
7b634a5 to
a132258
Compare
mattrco
reviewed
Oct 11, 2019
| logger.info(f"Getting channel ID for {name}") | ||
| next_cursor = None | ||
|
|
||
| while next_cursor != "": |
Contributor
There was a problem hiding this comment.
Suggested change
| while next_cursor != "": | |
| while next_cursor: |
Contributor
There was a problem hiding this comment.
I'm not sure why this includes a whitespace change.
mattrco
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for use in development. My instance tried to create comms channel #inc-101, but that channel existed already and had been archived, which the app didn't handle.