Nudge incident lead to complete a report on close #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrco
commented
Aug 20, 2019
|
|
||
| if instance.is_closed(): | ||
| user_to_notify = instance.lead or instance.reporter | ||
| doc_url = urljoin( |
Contributor
Author
There was a problem hiding this comment.
This could refactored into a model function, but it's only used here and to update the slack topic.
post_save only has access to the updated model (it's been written to the db, so we can't determine if the incident was just closed. Use pre_save which allows us to retrieve the current state and compare.
mattrco
force-pushed
the
mattrco/nudge-incident-report
branch
from
f406ad9 to
44e3c03
Compare
milesbxf
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a pre_save signal to determine if the incident has been closed by this operation (otherwise, if an incident is edited after close, this will fire again).