-
Notifications
You must be signed in to change notification settings - Fork 32
Speed up unit tests with synctest and optimized retry delays #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| func checkStatefulsetIsDeleted(ctx context.Context, memberClient kubernetesClient.Client, desiredSts *appsv1.StatefulSet, sleepDuration time.Duration, log *zap.SugaredLogger) bool { | ||
| func checkStatefulsetIsDeleted(ctx context.Context, memberClient kubernetesClient.Client, desiredSts *appsv1.StatefulSet, sleepDuration time.Duration, log *zap.SugaredLogger) (bool, int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returning retries makes testing easier
MCK 1.6.2 Release NotesBug Fixes
|
|
|
||
| func TestReconcilePVCResizeMultiCluster(t *testing.T) { | ||
| ctx := context.Background() | ||
| synctest.Test(t, func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noop, just wrapping synctest
Summary
Why
What
Proof of Work
Checklist
skip-changeloglabel if not needed