CLOUDP-359062 - add ownerrefs and only deleteAll in multicluster #620
Conversation
MCK 1.6.1 Release NotesBug Fixes
|
| --- | ||
| kind: fix | ||
| date: 2025-12-02 | ||
| --- | ||
|
|
||
| * **MongoDB** Adding missing ownerrefs to ensure proper resource deletion by kubernetes. | ||
| * **Single Cluster** Deleting resources created by CRD now only happens on multi-cluster deployments. Single Cluster will solely rely on ownerrefs. |
| clusterClient := item.Client | ||
| clusterName := item.Name | ||
| if err := r.commonController.deleteClusterResources(ctx, clusterClient, clusterName, sc, log); err != nil { | ||
| errs = multierror.Append(errs, xerrors.Errorf("failed deleting dependant resources in cluster %s: %w", clusterName, err)) |
There was a problem hiding this comment.
in om's controller we're only logging the error in this case
here though failing to delete will result in errors returned - would that impact anything?
There was a problem hiding this comment.
from zoom: lets clarify whether we want to use sharded or om controller approach. and why
There was a problem hiding this comment.
i am not sure whether its worth the effort to unify both.
Sharded interface onDelete returns error, while the one from om controller does not
but yeah in the end sharded collects those errors and them summarizes them again https://github.com/mongodb/mongodb-kubernetes/blob/d43f0840f0f0fed195bfe5e4d42d229[…]0f3022f3e/controllers/operator/mongodbresource_event_handler.go
i personally don't think its worth the hassle to unify them, but open for any opiniosn
| namespace string | ||
| resourceName string | ||
| ownerLabels map[string]string | ||
| ownerReferences []metav1.OwnerReference |
There was a problem hiding this comment.
how the stored owner refs are actually consumed by the controller's impl?
There was a problem hiding this comment.
check whether its even used. only used by configmap typemeta and not in the actual store
There was a problem hiding this comment.
its used here:
because i didn't want to change all writes to supply the owner
Summary
fixes: #589
This pull request introduces important improvements to how Kubernetes resources are managed and cleaned up for MongoDB and Ops Manager deployments, especially in multi-cluster versus single-cluster scenarios. The main focus is on correctly setting owner references for resources to enable automatic garbage collection by Kubernetes, and ensuring explicit resource deletion only occurs when necessary (i.e., in multi-cluster setups where owner references cannot span clusters).
Owner Reference Management & Resource Cleanup
ownerReferences) to all relevant ConfigMaps and resources for MongoDB and Ops Manager, ensuring proper automatic cleanup by Kubernetes in single-cluster deployments.appdbreplicaset_controller.go,mongodbopsmanager_controller.go,mongodbshardedcluster_controller.go,state_store.go) to consistently pass and setownerReferences.Multi-Cluster vs Single-Cluster Resource Deletion Logic
Proof of Work
Checklist
skip-changeloglabel if not needed